Francesco Romani has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device ......................................................................
Patch Set 4: Code-Review-1 (3 comments) looks good, but few questions inside, -1 for visibility https://gerrit.ovirt.org/#/c/56038/4/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: PS4, Line 159: key: value for key, value in : list_by_caps(device_cap).items() if : value['params']['parent'] == parent_name} nit: matching_devices = { key: value for key, value in list_by_caps(device_cap).items() if value['params']['parent'] == parent_name } seems a bit nicer, but please don't resubmit only for this. https://gerrit.ovirt.org/#/c/56038/4/tests/hostdevTests.py File tests/hostdevTests.py: PS4, Line 428: @permutations( please reformat as @permutations([ # device, unsuitable ['scsi_0_0_0_0']. #... ]) for better readability PS4, Line 430: hostdev.UnsuitableSCSIDevice why not just "true"? -- To view, visit https://gerrit.ovirt.org/56038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789f49c9abca2dff1487acf3e8a04ae1407956f4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
