Milan Zamazal has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/56038/5/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: Line 159: key: value for key, value in Line 160: list_by_caps(device_cap).items() if Line 161: value['params']['parent'] == parent_name} Line 162: except KeyError: Line 163: raise Do we really want to fail here if *any* of the devices returned by list_by_caps() doesn't have a parent? Line 164: Line 165: try: Line 166: device_params = matching_devices.values()[0] Line 167: except IndexError: -- To view, visit https://gerrit.ovirt.org/56038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789f49c9abca2dff1487acf3e8a04ae1407956f4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
