Milan Zamazal has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device ......................................................................
Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56038/7/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: Line 204: device_params = matching_devices.values()[0] Line 205: except IndexError: Line 206: raise Line 207: else: Line 208: return device_params Do I overlook something or could this function be simplified as for device in list_by_caps(device_cap).values(): if is_parent(device, parent_name): return device else: raise IndexError Either it can or the tests should be improved as they pass with my version. :-) Line 209: Line 210: params = {} Line 211: Line 212: scsi_name = device_xml.find('name').text -- To view, visit https://gerrit.ovirt.org/56038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789f49c9abca2dff1487acf3e8a04ae1407956f4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
