Antoni Segura Puimedon has posted comments on this change.
Change subject: NIC hotplug should fail if setPortMirroring failed
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Just one stupid nitpick of style.
....................................................
File vdsm/libvirtvm.py
Line 1484: self.log.error("setPortMirroring for network %s
failed",
Line 1485: network, exc_info=True)
Line 1486: nicParams['portMirroring'] = mirroredNetworks
Line 1487: self.hotunplugNic({'nic': nicParams})
Line 1488: return {'status': \
This line escaping is not necessary.
Line 1489: {'code':
errCode['hotplugNic']['status']['code'],
Line 1490: 'message': e.message}}
Line 1491:
Line 1492: return {'status': doneCode, 'vmList': self.status()}
--
To view, visit http://gerrit.ovirt.org/8742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b62fdec5f2c1a462283ff591d24e7b6f526f9e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Meni Yakove <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
