Antoni Segura Puimedon has posted comments on this change.
Change subject: NIC hotplug should fail if setPortMirroring failed
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Just a minor style issue.
....................................................
File vdsm/libvirtvm.py
Line 1504: nic = dev
Line 1505: break
Line 1506:
Line 1507: if nic:
Line 1508: if nicParams.has_key('portMirroring'):
Sorry to nitpick in such a way, but could we have a more pythonic (and more
forward compatible):
if 'portMirroring' in nicParams:
Line 1509: for network in nicParams['portMirroring']:
Line 1510: supervdsm.getProxy().unsetPortMirroring(network,
nic.name)
Line 1511:
Line 1512: nicXml = nic.getXML().toprettyxml(encoding='utf-8')
--
To view, visit http://gerrit.ovirt.org/8742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b62fdec5f2c1a462283ff591d24e7b6f526f9e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Meni Yakove <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
