Antoni Segura Puimedon has posted comments on this change. Change subject: NIC hotplug should fail if setPortMirroring failed ......................................................................
Patch Set 2: (1 inline comment) another minor thing. .................................................... File vdsm/libvirtvm.py Line 1469: self.conf['devices'].append(nicParams) Line 1470: self.saveState() Line 1471: self._getUnderlyingNetworkInterfaceInfo() Line 1472: Line 1473: mirroredNetworks = [] This declaration with initialization belongs to the case when nic has portMirroring. Thus, it should be moved inside its block. Line 1474: if hasattr(nic, 'portMirroring'): Line 1475: try: Line 1476: for network in nic.portMirroring: Line 1477: supervdsm.getProxy().setPortMirroring(network, nic.name) -- To view, visit http://gerrit.ovirt.org/8742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1b62fdec5f2c1a462283ff591d24e7b6f526f9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
