Saggi Mizrahi has posted comments on this change.
Change subject: itmap starts threads for each argument causes too many oop
operations
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/fileSD.py
Line 487: log.warn("Could not collect metadata file for domain path
%s",
Line 488: possibleDomain, exc_info=True)
Line 489:
Line 490: for res in misc.itmap(collectMetaFiles, mntList,
Line 491: config.getint("irs",
"process_pool_max_slots_per_domain")):
Never access config from places other then hsm or clientif.
Also, this can fail too. The value here is the amount of stuck domains we are
willing to handle +1. I'd put a comment about it and use 30% of the available
slots
Line 492: if res is None:
Line 493: continue
Line 494:
Line 495: yield res
--
To view, visit http://gerrit.ovirt.org/8745
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2877c28b916475aead16d47d37522c2bf44cc16
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
