Saggi Mizrahi has posted comments on this change.
Change subject: itmap starts threads for each argument causes too many oop
operations
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 1281: # This not supposed to happened. If it does, it's a
bug.
Line 1282: # maxthreads should get to 0 only after threadsCount
is
Line 1283: # greater than 1
Line 1284: if threadsCount < 1:
Line 1285: raise Exception("No thread initiated")
Never throw a general exception. RuntimeError should suffice as this should
never happen.
Line 1286: else:
Line 1287: yield respQueue.get()
Line 1288: # if yield returns one thread stopped, so we can
run
Line 1289: # another thread in queue
--
To view, visit http://gerrit.ovirt.org/8745
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2877c28b916475aead16d47d37522c2bf44cc16
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
