Dan Kenigsberg has posted comments on this change.
Change subject: itmap starts threads for each argument causes too many oop
operations
......................................................................
Patch Set 4: Looks good to me, approved
(1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 1283: # greater than 1
Line 1284: if threadsCount < 1:
Line 1285: raise RuntimeError("No thread initiated")
Line 1286: else:
Line 1287: yield respQueue.get()
There's a minor issue here: if the caller of itmap() performs a long operation
in each "yield", we loose time that could have been spent on issuing a new
threads.
Still I think that's good enough for our use case.
Line 1288: # if yield returns one thread stopped, so we can
run
Line 1289: # another thread in queue
Line 1290: maxthreads += 1
Line 1291: threadsCount -= 1
--
To view, visit http://gerrit.ovirt.org/8745
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2877c28b916475aead16d47d37522c2bf44cc16
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
