Martin Polednik has posted comments on this change. Change subject: cdrom: API change: require index ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56805/1/vdsm/API.py File vdsm/API.py: Line 112: def __init__(self, UUID): Line 113: APIBase.__init__(self) Line 114: self._UUID = UUID Line 115: Line 116: def changeCD(self, interface, index, driveSpec): > Why not keep single parameter (driveSpec), and include the interface and th This was my initial idea, there is one annoying problem though: driveSpec is union and contains ['DriveSpecVolume', 'DriveSpecGUID', 'DriveSpecUUID', 'DriveSpecPayload', 'DriveSpecPath']. That is kind of unfortunate in this case as we'd have to add both to all of these - if you're fine with that, OK but your future-ack is needed first. Line 117: """ Line 118: Change the CD in the specified VM. Line 119: Line 120: :param vmId: uuid of specific VM. -- To view, visit https://gerrit.ovirt.org/56805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178c1a02bbad962f9dc9b67bed7691cf170ee896 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches