Shahar Havivi has posted comments on this change. Change subject: v2v: get_external_vms returns additional info for kvm images ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/56912/4/lib/vdsm/v2v.py File lib/vdsm/v2v.py: PS4, Line 868: _add_graphics > you could split this part from the storage one. This part looks ready and c Done PS4, Line 953: e = root.find('./devices/video/model/[@type]') : if e is not None: : params['video'] = e.get('type') > in case you split this patch in virt and storage, please make two functions Done -- To view, visit https://gerrit.ovirt.org/56912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d4985aafc21e5ff5c11ec7bca71ab9aa5b2cd9d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
