Shahar Havivi has posted comments on this change. Change subject: v2v: get_external_vms returns additional info for kvm images ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56912/3/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 938: if driver is not None: Line 939: try: Line 940: format = driver.get('type') Line 941: fid = volume.str2fmt(format) Line 942: d["format"] = volume.VOLUME_TYPES[fid] the new str2fmt() return the index is using VOLUME_TYPES is the right way to get the string? Line 943: except KeyError: Line 944: logging.warning("Disk %s has unsupported format: %r", d, Line 945: format) Line 946: params['disks'].append(d) -- To view, visit https://gerrit.ovirt.org/56912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d4985aafc21e5ff5c11ec7bca71ab9aa5b2cd9d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
