Douglas Schilling Landgraf has posted comments on this change.
Change subject: make vdsm/storage/hsm.py PEP8 clean
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(3 inline comments)
Looks good to me, however, can you please replace rhev-m strings as well?
Thanks!
....................................................
File vdsm/storage/hsm.py
Line 512:
Line 513: vars.task.getExclusiveLock(STORAGE, spUUID)
Line 514: pool = self.getPool(spUUID)
Line 515: # We should actually just return true if we are SPM after
lock,
Line 516: # but seeing as it would break the API with RHEVM,
RHEVM -> Engine
Line 517: # it's easiest to fail.
Line 518: self.validateNotSPM(spUUID)
Line 519:
Line 520: vars.task.setTag("hsm")
Line 1385: misc.parseBool(postZero),
misc.parseBool(force))
Line 1386: # This is a hack to keep the interface consistent
Line 1387: # We currently have race conditions in delete image, to
quickly fix
Line 1388: # this we delete images in the "synchronous" state. This
only works
Line 1389: # because rhev-m does not send two requests at a time.
This hack is
rhev-m -> Engine
Line 1390: # intended to quickly fix the integration issue with
rhev-m. In 2.3
Line 1391: # we should use the new resource system to synchronize
the process
Line 1392: # an eliminate all race conditions
Line 1393: self._spmSchedule(spUUID, "deleteImage", lambda: True)
Line 1386: # This is a hack to keep the interface consistent
Line 1387: # We currently have race conditions in delete image, to
quickly fix
Line 1388: # this we delete images in the "synchronous" state. This
only works
Line 1389: # because rhev-m does not send two requests at a time.
This hack is
Line 1390: # intended to quickly fix the integration issue with
rhev-m. In 2.3
rhev-m -> Engine
Line 1391: # we should use the new resource system to synchronize
the process
Line 1392: # an eliminate all race conditions
Line 1393: self._spmSchedule(spUUID, "deleteImage", lambda: True)
Line 1394:
--
To view, visit http://gerrit.ovirt.org/4530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9b2f8b9e83db6f52678b4e0865668a79bcf53f5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
