Zhou Zheng Sheng has posted comments on this change.
Change subject: make vdsm/storage/hsm.py PEP8 clean
......................................................................
Patch Set 10: Verified
I update my pep8 tool to 1.3.3, it now checks indentation of continued lines.
Although we suppress the those errors in make check, I take some time to fix
those problems in hsm.py. I hope it might help.
Pass autobuild.sh. Verify with pydiff, it finds 3 changes.
pydiff hsm*.py
3 difference(s)
first file: hsmo.py
second file: hsm.py
((1324, 'Cannot delete shared image%s. volImgs: %s'),
(1425, 'Cannot delete shared image %s. volImgs: %s'))
((1792, '=='), (1918, 'is'))
((1793,
"Compare(CallFunc(Name('type'), [Name('force')], None, None), [('==',
CallFunc(Name('type'), [Const('')], None, None))])"),
(1918,
"CallFunc(Name('isinstance'), [Name('force'), Name('str')], None, None)"))
In fact in the original file, a string in line 1324 is wrapped incorrectly, it
missed a space. This is corrected in this patch. The first difference report
item is about that.
The other two changes are acceptable as well, the reason is in previous code
review comments.
--
To view, visit http://gerrit.ovirt.org/4530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9b2f8b9e83db6f52678b4e0865668a79bcf53f5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
