Mark Wu has posted comments on this change. Change subject: make vdsm/storage/hsm.py PEP8 clean ......................................................................
Patch Set 7: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/storage/hsm.py Line 1338: """ Line 1339: Delete a volume Line 1340: """ Line 1341: argsStr = "sdUUID=%s, spUUID=%s, imgUUID=%s, volumes=%s, postZero=%s" \ Line 1342: ", force=%s" % (sdUUID, spUUID, imgUUID, volumes, postZero, it's a little weird to start with comma. Line 1343: force) Line 1344: vars.task.setDefaultException(se.CannotDeleteVolume(argsStr)) Line 1345: # Validates that the pool is connected. WHY? Line 1346: pool = self.getPool(spUUID) -- To view, visit http://gerrit.ovirt.org/4530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b2f8b9e83db6f52678b4e0865668a79bcf53f5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
