ShaoHe Feng has posted comments on this change.
Change subject: Applied PEP-8 guideline on code
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File Makefile.am
Line 65: vdsm/momIF.py \
Line 66: vdsm/neterrors.py \
Line 67: vdsm/netinfo.py \
Line 68: vdsm/parted_utils.py \
Line 69: vdsm/vm.py \
you should sort pep8 white list.
Line 70: vdsm/rest/BindingREST.py \
Line 71: vdsm/rest/Controller.py \
Line 72: vdsm/storage/blockVolume.py \
Line 73: vdsm/storage/devicemapper.py \
Line 96: vdsm/storage/volume.py \
Line 97: vdsm/supervdsm.py \
Line 98: vdsm/supervdsmServer.py \
Line 99: vdsm/tc.py \
Line 100: vdsm/vdsm \
"vdsm/vm.py \" here?
Line 101: vdsm/vdsmDebugPlugin.py \
Line 102: vdsm_cli \
Line 103: vdsm_hooks/fileinject \
Line 104: vdsm_hooks/promisc/after_vm_start.py \
....................................................
File vdsm/vm.py
Line 800:
Line 801: if newSize is None:
Line 802: # newSize is always in megabytes
Line 803: newSize = (config.getint('irs',
'volume_utilization_chunk_mb') +
Line 804: ((vmDrive.apparentsize + constants.MEGAB - 1) /
slash is not needed.
Line 805: constants.MEGAB))
Line 806:
Line 807: if getattr(vmDrive, 'diskReplicate', None):
Line 808: volInfo = {'poolID': vmDrive.diskReplicate['poolID'],
Line 1136: return stats
Line 1137: memUsage = 0
Line 1138: realMemUsage = int(stats['memUsage'])
Line 1139: if realMemUsage != 0:
Line 1140: memUsage = (100 - float(realMemUsage) /
slash is not needed.
Line 1141: int(self.conf['memSize']) * 100)
Line 1142: stats['memUsage'] = utils.convertToStr(int(memUsage))
Line 1143: stats['balloonInfo'] = self._getBalloonInfo()
Line 1144: return stats
--
To view, visit http://gerrit.ovirt.org/8933
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b1ce77b01d848adb008d375decb2c214617ad2e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
