Dan Kenigsberg has posted comments on this change.
Change subject: Applied PEP-8 guideline on code
......................................................................
Patch Set 5: Looks good to me, approved
(2 inline comments)
....................................................
File vdsm/vm.py
Line 364: BALLOON_DEVICES: [], REDIR_DEVICES: []}
Line 365:
Line 366: def _get_lastStatus(self):
Line 367: PAUSED_STATES = ('Powering down', 'RebootInProgress', 'Up')
Line 368: if not self._guestCpuRunning and self._lastStatus in
PAUSED_STATES:
why is this change pep8-related? (I don't REALLY care)
Line 369: return 'Paused'
Line 370: return self._lastStatus
Line 371:
Line 372: def _set_lastStatus(self, value):
Line 410: """
Line 411: Backward compatibility for qa scripts that specify direct
paths.
Line 412: """
Line 413: legacies = []
Line 414: DEVICE_SPEC = ((0, 'hda'), (1, 'hdb'), (2, 'hdc'), (3, 'hdd'))
I don't think this name is pretty good - drivespec is used for completely
different thing
Line 415: for index, linuxName in DEVICE_SPEC:
Line 416: path = self.conf.get(linuxName)
Line 417: if path:
Line 418: legacies.append({'type': DISK_DEVICES, 'device':
'disk',
--
To view, visit http://gerrit.ovirt.org/8933
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b1ce77b01d848adb008d375decb2c214617ad2e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
