Vinzenz Feenstra has posted comments on this change.
Change subject: Applied PEP-8 guideline on code
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/vm.py
Line 332: self._lastStatus = 'WaitForLaunch'
Line 333: self._migrationSourceThread =
self.MigrationSourceThreadClass(self)
Line 334: self._kvmEnable = self.conf.get('kvmEnable', 'true')
Line 335: self._guestSocketFile = constants.P_VDSM_RUN +
self.conf['vmId'] + \
Line 336: '.guest.socket'
However this is following PEP8 the previous one is not. We have just too many
things disabled in our checks, that's why we do not see those kind of errors.
Line 337: self._incomingMigrationFinished = threading.Event()
Line 338: self.id = self.conf['vmId']
Line 339: self._volPrepareLock = threading.Lock()
Line 340: self._initTimePauseCode = None
--
To view, visit http://gerrit.ovirt.org/8933
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b1ce77b01d848adb008d375decb2c214617ad2e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
