Edward Haas has posted comments on this change.

Change subject: virt net: Change graphics type from network to address
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59336/1/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.py:

Line 237:             return dev
Line 238:     return None
Line 239: 
Line 240: 
Line 241: def _getNetworkIp(network):
In a future patch, query the IP information from vdsm and no libvirt.
Line 242:     try:
Line 243:         nets = net_api.libvirt_networks()
Line 244:         device = nets[network].get('iface', network)
Line 245:         ip, _, _, _ = net_api.ip_addrs_info(device)


-- 
To view, visit https://gerrit.ovirt.org/59336
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0724627bd6c37ce11f943c8818fcd5b559fdf070
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Edward Haas <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to