Edward Haas has posted comments on this change. Change subject: virt net: Change graphics type from network to address ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59336/1/tests/deviceTests.py File tests/deviceTests.py: PS1, Line 50: 10.10.10.10 > Applies to this and all addresses below: please make sure we conform to RFC That RFC is for documentation, not for test or internal usage. 10.0.0.0/8 is in the private address scope and can be used for testing. The addresses in the RFC are reserved for documentation, which means they can be blocked/filtered by implementations, making our tests unusable (in theory). -- To view, visit https://gerrit.ovirt.org/59336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0724627bd6c37ce11f943c8818fcd5b559fdf070 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
