Edward Haas has posted comments on this change. Change subject: virt net: Change graphics type from network to address ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/59336/2/vdsm/virt/vmdevices/graphics.py File vdsm/virt/vmdevices/graphics.py: Line 140: for chan in self._getSpiceChannels(): Line 141: graphics.appendChildWithArgs('channel', name=chan, Line 142: mode='secure') Line 143: Line 144: if self.specParams.get('displayIp', '0') != '0': The listen address type should be used only if the display network is an OVS one. This assumes that the cluster in which the host operates is OVS enabled and all other hosts in the cluster have the migration hook installed. Line 145: graphics.appendChildWithArgs( Line 146: 'listen', type='address', address=self.specParams['displayIp']) Line 147: else: Line 148: graphics.setAttrs(listen='0') -- To view, visit https://gerrit.ovirt.org/59336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0724627bd6c37ce11f943c8818fcd5b559fdf070 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
