Nir Soffer has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/59306/9/Makefile.am File Makefile.am: Line 82: Line 83: .PHONY: pyflakes Line 84: pyflakes: Line 85: if [ -x "$(TOX)" ]; then \ Line 86: if [[ ! `tox --version | cut -d' ' -f1` < $(TOX_MIN_VERSION) ]]; \ > can you try to check if in configure.ac we can validate the version as well We may be able to do this in configure, but do you cannot fail configure since it will fail build on downstream. The best place to fail is here, when you try to use tox. Line 87: then \ Line 88: tox -- pyflakes ; \ Line 89: else \ Line 90: echo "Warning: skipping check since tox is too old \ -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
