Irit Goihman has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. ......................................................................
Patch Set 10: (6 comments) https://gerrit.ovirt.org/#/c/59306/10//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-06-14 15:00:54 +0300 Line 4: Commit: Irit Goihman <igoih...@redhat.com> Line 5: CommitDate: 2016-06-22 19:15:38 +0300 Line 6: Line 7: tox: skip code style validation if required tox version isn't > try to keep title in one line Done Line 8: installed. Line 9: Line 10: Over RHEL 7.2 yum contains only tox-1.4.2 which doesn't fit to vdsm Line 11: requirements. https://gerrit.ovirt.org/#/c/59306/9/Makefile.am File Makefile.am: Line 81: echo "Missing absolute_import in $$f"; exit 1; fi; \ Line 82: done; Line 83: Line 84: .PHONY: pyflakes Line 85: pyflakes: > do we? oh, missed that. Done Line 86: if [ -x "$(TOX)" ]; then \ Line 87: if ! build-aux/vercmp `tox --version | cut -d' ' -f1` "$(TOX_MIN_VERSION)" | grep "True" > /dev/null; \ Line 88: then \ Line 89: tox -- pyflakes ; \ https://gerrit.ovirt.org/#/c/59306/10/Makefile.am File Makefile.am: Line 82: done; Line 83: Line 84: .PHONY: pyflakes Line 85: pyflakes: Line 86: if [ -x "$(TOX)" ]; then \ > if we check it in configure we don't need to check it here. I think we want Done - removed tox check since it's already being checked in cofigure.ac Line 87: if ! build-aux/vercmp `tox --version | cut -d' ' -f1` "$(TOX_MIN_VERSION)" | grep "True" > /dev/null; \ Line 88: then \ Line 89: tox -- pyflakes ; \ Line 90: else \ Line 87: if ! build-aux/vercmp `tox --version | cut -d' ' -f1` "$(TOX_MIN_VERSION)" | grep "True" > /dev/null; \ Line 88: then \ Line 89: tox -- pyflakes ; \ Line 90: else \ Line 91: echo "Error: skipping check since tox is too old \ > be specific - PYFLAKES CHECK ERROR: ... Done Line 92: please install tox $(TOX_MIN_VERSION) or later."; \ Line 93: exit 1; \ Line 94: fi \ Line 95: else \ Line 99: .PHONY: pep8 Line 100: pep8: Line 101: if [ -x "$(TOX)" ]; then \ Line 102: if ! build-aux/vercmp `tox --version | cut -d' ' -f1` "$(TOX_MIN_VERSION)" | grep "True" > /dev/null; \ Line 103: then \ > don't pass 80 chars in line Done Line 104: tox -- pep8 ; \ Line 105: else \ Line 106: echo "Error: skipping check since tox is too old \ Line 107: please install tox $(TOX_MIN_VERSION) or later."; \ https://gerrit.ovirt.org/#/c/59306/10/build-aux/vercmp File build-aux/vercmp: Line 1: #!/usr/bin/python > add copyrights comment Done Line 2: Line 3: import argparse Line 4: from six.moves import zip, zip_longest Line 5: import sys -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
