Tomas Golembiovsky has uploaded a new change for review. Change subject: pep8: Excluded files were not excluded from check ......................................................................
pep8: Excluded files were not excluded from check The files listed for exclusion were not excluded from PEP8 check. This had two reasons. First the exclusion pattern was improperly composed, because $$ was used to expand variables instead of a single $. This is because the script snippet originated from Makefile. Second problem was that `pep8` does accept only one `--except` argument. This meant that the first pattern list (which contained garbage anyway) was ignored. Change-Id: I40f8485f0ced9c117d3416967a11dc6aef3a1dfe Signed-off-by: Tomáš Golembiovský <[email protected]> --- M tox.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/59623/1 diff --git a/tox.sh b/tox.sh index 5d01520..717f547 100755 --- a/tox.sh +++ b/tox.sh @@ -33,9 +33,9 @@ if [ 'pep8' = "$1" ]; then for x in ${PEP8_BLACKLIST[@]}; do \ - exclude="$${exclude},$${x}" ; \ + exclude="${exclude},${x}" ; \ done ; \ - pep8 --exclude="$${exclude}" --exclude='.tox/*' \ + pep8 --exclude="${exclude},.tox" \ --filename '*.py' . \ "${WHITELIST[@]}" fi -- To view, visit https://gerrit.ovirt.org/59623 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I40f8485f0ced9c117d3416967a11dc6aef3a1dfe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
