Tomas Golembiovsky has posted comments on this change.

Change subject: pep8: Excluded files were not excluded from check
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59623/1/tox.sh
File tox.sh:

Line 34
Line 35
Line 36
Line 37
Line 38
> well.. I have no problem with this patch. But locally and in jenkins, it ne
Well I found it rather strange that nobody noticed it sooner. For me it runs 
the check on all the blacklisted files and reports errors.

Could you please recheck it realy works for you the way it is? Try adding the 
'-v' argument, it will print the names of all files it checks.


-- 
To view, visit https://gerrit.ovirt.org/59623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40f8485f0ced9c117d3416967a11dc6aef3a1dfe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Irit Goihman <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Tomas Golembiovsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to