Nir Soffer has submitted this change and it was merged. Change subject: pep8: Excluded files were not excluded from check ......................................................................
pep8: Excluded files were not excluded from check The files listed for exclusion were not excluded from PEP8 check. This had two reasons. First the exclusion pattern was improperly composed, because $$ was used to expand variables instead of a single $. This is because the script snippet originated from Makefile. Second problem was that `pep8` does accept only one `--except` argument. This meant that the first pattern list (which contained garbage anyway) was ignored. Change-Id: I40f8485f0ced9c117d3416967a11dc6aef3a1dfe Signed-off-by: Tomáš Golembiovský <[email protected]> Reviewed-on: https://gerrit.ovirt.org/59623 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <[email protected]> Reviewed-by: Piotr Kliczewski <[email protected]> --- M tox.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Tomas Golembiovsky: Verified -- To view, visit https://gerrit.ovirt.org/59623 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40f8485f0ced9c117d3416967a11dc6aef3a1dfe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Tomas Golembiovsky <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
