Nir Soffer has posted comments on this change. Change subject: vdsm: Conditional hard dependency on gluster rpms ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/58605/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-06-09 12:54:11 +0530 Line 6: Line 7: vdsm: Conditional hard dependency on gluster rpms Line 8: Line 9: Removed with_gluster_mgmt to always build vdsm-gluster > Yes, vdsm-gluster will be built, but will only be required to be installed OK, sounds fine. Line 10: Line 11: Made the dependency of vdsm & vdsm-gluster on Line 12: gluster-client & glusterfs-server packages conditional. Line 13: The gluster packages will be pulled in Line 11: Made the dependency of vdsm & vdsm-gluster on Line 12: gluster-client & glusterfs-server packages conditional. Line 13: The gluster packages will be pulled in Line 14: by ovirt-host-deploy when added to Line 15: gluster enabled cluster > I can add the gluster-mgmt flag back to provide flexibility. but the curren We can simply remove the --disable-gluster-mgmt flag in contrib/rhev_build.sh - wouldn't it be enough for downstream build? We can discuss later if we want to remove the gluster_mgmt flag. Line 16: Line 17: Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117 Line 18: Bug-Url: https://bugzilla.redhat.com/1225728 -- To view, visit https://gerrit.ovirt.org/58605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
