Nir Soffer has posted comments on this change. Change subject: vdsm: Conditional hard dependency on gluster rpms ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/58605/2/vdsm.spec.in File vdsm.spec.in: Line 711: %package gluster Line 712: Summary: Gluster Plugin for VDSM Line 713: BuildArch: noarch Line 714: Requires: %{name} = %{version}-%{release} Line 715: %if 0%{?with_gluster_deps} > The glusterfs-server packages are installed as part of host deploy for any Having --with-gluser-deps option to create a broken package that does not require the packages it depends on cannot be done in upstream code. If you want to remove the dependency on vdsm-gluster, so it will allow managing gluster server if one was installed, the code must be change to use soft dependency. If gluster is not installed, all verbs must fail with clear error message. We have similar soft dependency on glusterfs-cli, so gluster storage domain can work with or without this package. Line 716: Requires: glusterfs-server >= %{gluster_version} Line 717: Requires: glusterfs-api >= %{gluster_version} Line 718: Requires: glusterfs-geo-replication >= %{gluster_version} Line 719: %endif -- To view, visit https://gerrit.ovirt.org/58605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
