Nir Soffer has posted comments on this change. Change subject: vdsm: Conditional hard dependency on gluster rpms ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/58605/2/vdsm.spec.in File vdsm.spec.in: Line 1637 Line 1638 Line 1639 Line 1640 Line 1641 > with_gluster_mgmt flag was added to filter out vdsm-gluster and related fil But this file is needed only if vdsm-gluster package is installed. The correct way is to move it into vdsm-gluster. Line 711: %package gluster Line 712: Summary: Gluster Plugin for VDSM Line 713: BuildArch: noarch Line 714: Requires: %{name} = %{version}-%{release} Line 715: %if 0%{?with_gluster_deps} > Why these packages are always needed now? This condition does not make sense. You build a vdsm-gluster package for using vdsm as a gluster node manager, but the package does not require glusterfs-server. I think we should simplify things. The only thing that we must have for rhel is not require gluster client packages, which may not be available. So I would add a flag with_gluster_client and require the client packages only if the flag is enabled. The flag will be enabled by default and disabled when building on rhel. The client package dependencies will be satisfied by host deploy. Sahina, will this work for you? Line 716: Requires: glusterfs-server >= %{gluster_version} Line 717: Requires: glusterfs-api >= %{gluster_version} Line 718: Requires: glusterfs-geo-replication >= %{gluster_version} Line 719: %endif -- To view, visit https://gerrit.ovirt.org/58605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
