Nir Soffer has posted comments on this change. Change subject: migration: use reactor per connection ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59720/3//COMMIT_MSG Commit Message: Line 6: Line 7: migration: use reactor per connection Line 8: Line 9: We need to make sure that reactor is not reused between incoming and Line 10: outgoing connections. > when close on a client (outgoing connection) is called we close reactor as Ok, so the issue using a shared reactor, or your own reactor. The client should close the reactor only if it owns the reactor. We should have a own_reactor in the client, set to True only when you create a standalone client without a reactor. Closing the reactor that you don't own is an error. Line 11: Line 12: Line 13: Backport-To: 4.0 Line 14: Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d -- To view, visit https://gerrit.ovirt.org/59720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
