Nir Soffer has posted comments on this change. Change subject: migration: usage of single reactor in vdsm ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/59720/4//COMMIT_MSG Commit Message: Line 7: migration: usage of single reactor in vdsm Line 8: Line 9: In most of the cases for each standalone client there is reactor but Line 10: we want to share one in vdsm. There are already too many threads in vdsm Line 11: so it is not desired to add more. Lets update to reflect the behavior in the current version of the patch. I think it is important to explain that by default StompClient owns its client to simplify user code and prevent leaks. More sophisticated users creating a client from StompReactor, sharing the same reactor by many clients can use a flag to mark the reactor as shared. Line 12: Line 13: Line 14: Backport-To: 4.0 Line 15: Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d https://gerrit.ovirt.org/#/c/59720/4/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 464: def server(self): Line 465: return self._server Line 466: Line 467: def createClient(self, connected_socket, owns_reactor=False): Line 468: return StompClient(connected_socket, self._reactor, owns_reactor) This should use kwargs call style - owns_reactor=owns_reactor. Line 469: Line 470: def process_requests(self): Line 471: self._reactor.process_requests() Line 472: -- To view, visit https://gerrit.ovirt.org/59720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
