Piotr Kliczewski has posted comments on this change. Change subject: migration: use reactor per connection ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59720/3//COMMIT_MSG Commit Message: Line 6: Line 7: migration: use reactor per connection Line 8: Line 9: We need to make sure that reactor is not reused between incoming and Line 10: outgoing connections. > Here is an untested draft implementing my suggestion - please check. I reviewed your suggestion and I think that it is not enough to fix the issue. On one hand we want to simplify client code as much as possible but on the other hand we want to expose this detail to the user. Majority of the clients would have their on reactors. Only internal to vdsm clients could share the reactor. If I wanted to introduce "own_reactor" I would provide default as True. Having this option could confuse users. I agree that closing reactor which is used by others is an error so to make it simile we make all the clients to own one. Line 11: Line 12: Line 13: Backport-To: 4.0 Line 14: Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d -- To view, visit https://gerrit.ovirt.org/59720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
