Yaniv Bronhaim has uploaded a new change for review. Change subject: Alert if vdsm log has wrong user\group permissions ......................................................................
Alert if vdsm log has wrong user\group permissions Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=870139 Change-Id: I8bd379803b01627d6897992ee8798c6a22195b0f Signed-off-by: Yaniv Bronhaim <[email protected]> --- M vdsm/vdsmd.init.in 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/9118/1 diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in index 5b38d55..a3d8471 100755 --- a/vdsm/vdsmd.init.in +++ b/vdsm/vdsmd.init.in @@ -102,6 +102,18 @@ done } +verify_log_permissions() { + VDSM_USER=`id -u vdsm` + VDSM_GROUP=`id -g vdsm` + LOG_OWNER=`stat -c "%u" @VDSMLOGDIR@/vdsm.log` + LOG_GROUP=`stat -c "%g" @VDSMLOGDIR@/vdsm.log` + if [[ $VDSM_USER -ne $LOG_OWNER || $VDSM_GROUP -ne $LOG_GROUP ]]; + then + return 1 + fi + return 0 +} + get_libvirt_conf_item() { local cfile key @@ -496,6 +508,11 @@ return 1 fi + if [[ verify_log_permissions != 0 ]]; + then + log_failure_msg "Permissions error with vdsm log file" + fi + echo $"Starting up vdsm daemon: " local vdsm_nice=`$GETCONFITEM $CONF_FILE vars vdsm_nice -5` -- To view, visit http://gerrit.ovirt.org/9118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8bd379803b01627d6897992ee8798c6a22195b0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
