Shu Ming has posted comments on this change.
Change subject: Alert if vdsm log has wrong user\group permissions
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/vdsmd.init.in
Line 506: test_conflicting_conf); then
Line 507: return 1
Line 508: fi
Line 509:
Line 510: if ! verify_log_permissions; then
It seems that verify_log_permssion() use return value 0 as successful flag. I
think the if condition check should be:
if verify_log_permissions; then
...
Line 511: log_failure_msg "Permissions error with vdsm log file"
Line 512: return 1
Line 513: fi
Line 514:
--
To view, visit http://gerrit.ovirt.org/9118
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bd379803b01627d6897992ee8798c6a22195b0f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
