Petr Horáček has posted comments on this change. Change subject: net: introduce acquire module ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/60974/5/tests/network/acquire_ifaces_test.py File tests/network/acquire_ifaces_test.py: Line 90: def test_acquire_ifcfg_persisted_nic(self, mock_os, mock_ifcfg): Line 91: mock_os.path.isfile.return_value = True Line 92: mock_ifcfg.ifdown.return_value = None Line 93: Line 94: mock_file = PersistingStringIO(NIC_IFCFG) > Have you specified what readlines() returns? I set only mock_open(read_data=...) I will try to mock readlines as well. Line 95: with mock.patch('vdsm.network.acquire.open', return_value=mock_file, Line 96: create=True): Line 97: Line 98: acquire.acquire_unowned_ifaces( -- To view, visit https://gerrit.ovirt.org/60974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
