Edward Haas has posted comments on this change. Change subject: net: introduce acquire module ......................................................................
Patch Set 11: Code-Review-1 (3 comments) Partial review https://gerrit.ovirt.org/#/c/60974/11/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS11, Line 164: disable NM This needs to happen before we start the setup transaction as a pre requirement. Or do we make sure no changes are applied before exiting the context? Line 167: _setup_ipv6autoconf(networks) Line 168: _set_ovs_links_up(nets2add, bonds2add, bonds2edit) Line 169: _setup_ovs_ip_config(nets2add, nets2remove) Line 170: connectivity.check(options) Line 171: # TODO: set onboot=no This needs to be done on 'safe' verb, not here. Line 172: Line 173: Line 174: def _update_running_config(networks, bondings, running_config): Line 175: """Update running_config with expected configuration. https://gerrit.ovirt.org/#/c/60974/11/tests/testlib.py File tests/testlib.py: Line 578: with open(path) as src: Line 579: return src.read() Line 580: Line 581: Line 582: class PersistingStringIO(io.StringIO): Not needed anymore, right? Line 583: """Keeps its contents even after it's closed. Can be used to mock files.""" Line 584: Line 585: def __init__(self, *args, **kwargs): Line 586: self._pre_close_content = None -- To view, visit https://gerrit.ovirt.org/60974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
