Francesco Romani has posted comments on this change. Change subject: sampling: refactor tests ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/61309/1//COMMIT_MSG Commit Message: PS1, Line 7: sampling: refactor tests > tests: add (robust) fake monotonic clock? better, yes. Will change. https://gerrit.ovirt.org/#/c/61309/1/tests/samplingTests.py File tests/samplingTests.py: PS1, Line 240: @property : def frozen(self): : return self._frozen > I don't like this. Just access the attribute directly. We don't actually need this yet, so I'll just drop this. -- To view, visit https://gerrit.ovirt.org/61309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic88fc4e5f625ed97aa68bba87e1979ff06621b5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org