Martin Polednik has posted comments on this change. Change subject: sampling: refactor tests ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/61309/1/tests/samplingTests.py File tests/samplingTests.py: PS1, Line 240: @property : def frozen(self): : return self._frozen > We don't actually need this yet, so I'll just drop this. If you mean dropping the attribute, I'd keep it and note that it's used in future patch (in a commit message for example). -- To view, visit https://gerrit.ovirt.org/61309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic88fc4e5f625ed97aa68bba87e1979ff06621b5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
