Yaniv Bronhaim has posted comments on this change.

Change subject: Alert if vdsm log has wrong user\group permissions
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 101:         /sbin/restorecon "$run_path"
Line 102:     done
Line 103: }
Line 104: 
Line 105: verify_log_permissions() {
After some tests on Dan's suggestion I figure that it works alright only over 
fedora 17. Somehow this function constantly returns failure over rhel, probably 
because the differences in 'su' implementation. 
I'll try to explore it more, but any advice or another verification on your 
machines can help here..

thanks.
Line 106:     VDSM_USER=`id -u vdsm`
Line 107:     VDSM_GROUP=`id -g vdsm`
Line 108:     LOG_OWNER=`stat -c "%u" @VDSMLOGDIR@/vdsm.log`
Line 109:     LOG_GROUP=`stat -c "%g" @VDSMLOGDIR@/vdsm.log`


--
To view, visit http://gerrit.ovirt.org/9118
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bd379803b01627d6897992ee8798c6a22195b0f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to