Nir Soffer has posted comments on this change. Change subject: storage: Introduce guarded utilities ......................................................................
Patch Set 9: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/61435/9/lib/vdsm/storage/guarded.py File lib/vdsm/storage/guarded.py: Line 164: rmanager.releaseResource(self.ns, self.name) Line 165: Line 166: Line 167: class VolumeLease(LockInterface): Line 168: MODE = "exclusive" # All volume leases are exclusive Please address the comment from version 6: https://gerrit.ovirt.org/#/c/61435/6/lib/vdsm/storage/guarded.py Line 169: Line 170: def __init__(self, host_id, sd_id, img_id, vol_id): Line 171: self._host_id = host_id Line 172: self._sd_id = sd_id Line 174: self._vol_id = vol_id Line 175: Line 176: @property Line 177: def ns(self): Line 178: return sc.VOLUME_LEASE_NAMESPACE Please address the comment from version 6: https://gerrit.ovirt.org/#/c/61435/6/lib/vdsm/storage/guarded.py Line 179: Line 180: @property Line 181: def name(self): Line 182: return self._vol_id -- To view, visit https://gerrit.ovirt.org/61435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
