Adam Litke has posted comments on this change. Change subject: storage: Introduce guarded utilities ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/61435/9/lib/vdsm/storage/guarded.py File lib/vdsm/storage/guarded.py: Line 85: self._release() Line 86: except ReleaseError: Line 87: if exc_type is not None: Line 88: log.exception("Error releasing locks") Line 89: six.reraise(exc_type, exc_val, exc_tb) > We don't need this, please check again my comment from version 6, maybe you Sit tight. I haven't uploaded the changes yet. Coming soon. Line 90: raise Line 91: Line 92: def _release(self): Line 93: errors = [] -- To view, visit https://gerrit.ovirt.org/61435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
