Petr Horáček has posted comments on this change. Change subject: net: remove default route before adding a new one ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63220/1/lib/vdsm/network/ip/address.py File lib/vdsm/network/ip/address.py: PS1, Line 179: if ipwrapper.routeExists('default'): : ipwrapper.routeDel('default') > You can add a remark about it, but I think we should be ok with removing it If you try to remove non-existing route, you get IPRoute2Error 'No such process' IIUIC multiple default gateways are handled by multiple routing tables, so we will remove only the one from default table. -- To view, visit https://gerrit.ovirt.org/63220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie59c07845898630404ce517e5cc52048e50ed2dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
