Petr Horáček has posted comments on this change. Change subject: net: remove default route before adding a new one ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63220/1/lib/vdsm/network/ip/address.py File lib/vdsm/network/ip/address.py: PS1, Line 179: if ipwrapper.routeExists('default'): : ipwrapper.routeDel('default') > If you try to remove non-existing route, you get IPRoute2Error 'No such pro I was wrong. If you have multiple routes (one with no defined metric and many with defined one), `ip route del` first removes the one without defined metric and then the one with the lowest metric. I'm not sure if we can keep the original one and temporary override it with lower metric route. In `ip route` it shows the one withou metric always on top. -- To view, visit https://gerrit.ovirt.org/63220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie59c07845898630404ce517e5cc52048e50ed2dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
