Edward Haas has posted comments on this change. Change subject: net: remove default route before adding a new one ......................................................................
Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/63220/2/lib/vdsm/network/ip/address.py File lib/vdsm/network/ip/address.py: Line 183: if ipv4.gateway and ipv4.defaultRoute: Line 184: try: Line 185: ipwrapper.routeAdd(['default', 'via', ipv4.gateway]) Line 186: except ipwrapper.IPRoute2Error: # there already is a default route Line 187: ipwrapper.routeDel('default') How about logging that we removed a route? Line 188: ipwrapper.routeAdd(['default', 'via', ipv4.gateway]) Line 189: if ipv6: Line 190: _add_ipv6_address(iface, ipv6) Line 191: elif ipv6_supported(): PS2, Line 185: ipwrapper.routeAdd(['default', 'via', ipv4.gateway]) : except ipwrapper.IPRoute2Error: # there already is a default route : ipwrapper.routeDel('default') : ipwrapper.routeAdd(['default', 'via', ipv4.gateway]) worth its own function, can be shared with the ipv6 version. -- To view, visit https://gerrit.ovirt.org/63220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie59c07845898630404ce517e5cc52048e50ed2dd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
