Dan Kenigsberg has posted comments on this change. Change subject: pep8 fixes ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) ShaoHe Feng, Zhou, please pitch in to help with these too issues. Laszlo, on the mean time, you can fetch pep8 from upstream (or rebuild it from fedora 18) to solve the issue with "raise". .................................................... File vdsm/storage/misc.py Line 735: firstException = e Line 736: Line 737: # re-raise the earliest exception Line 738: if firstException is not None: Line 739: raise firstException this is more than just a pep8 change. please work with Zhou to solve this properly. Line 740: Line 741: def defer(self, func, *args, **kwargs): Line 742: self._finally.append((func, args, kwargs)) Line 743: -- To view, visit http://gerrit.ovirt.org/9366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbbba925fa0c9be78b0eb5eb3d07066dc3b3c5ab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
