ShaoHe Feng has posted comments on this change.
Change subject: pep8 fixes
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File vdsm/storage/misc.py
Line 731: undo(*args, **kwargs)
Line 732: except Exception as e:
Line 733: # keep the earliest exception info
Line 734: if not firstException:
Line 735: firstException = e
traceback should not be removed.
It record the stack frame information of firstException
also, I have check by the latest pep8 version. there is no error.
Line 736:
Line 737: # re-raise the earliest exception
Line 738: if firstException is not None:
Line 739: raise firstException
Line 735: firstException = e
Line 736:
Line 737: # re-raise the earliest exception
Line 738: if firstException is not None:
Line 739: raise firstException
agree with Dan.
also, I have check by the latest pep8 version. there is no error.
Line 740:
Line 741: def defer(self, func, *args, **kwargs):
Line 742: self._finally.append((func, args, kwargs))
Line 743:
....................................................
File vdsm/vm.py
Line 362: self._devices = {DISK_DEVICES: [], NIC_DEVICES: [],
Line 363: SOUND_DEVICES: [], VIDEO_DEVICES: [],
Line 364: CONTROLLER_DEVICES: [], GENERAL_DEVICES: [],
Line 365: BALLOON_DEVICES: [], REDIR_DEVICES: [],
Line 366: WATCHDOG_DEVICES: []}
agree
Line 367:
Line 368: def _get_lastStatus(self):
Line 369: PAUSED_STATES = ('Powering down', 'RebootInProgress', 'Up')
Line 370: if not self._guestCpuRunning and self._lastStatus in
PAUSED_STATES:
Line 495: if not 'specParams' in devices[WATCHDOG_DEVICES][0]:
Line 496: devices[WATCHDOG_DEVICES][0]['specParams'] = {}
Line 497: if not 'model' in
devices[WATCHDOG_DEVICES][0]['specParams']:
Line 498: devices[WATCHDOG_DEVICES][0]['specParams']['model'] =
\
Line 499: 'i6300esb'
agree
Line 500: if not 'action' in
devices[WATCHDOG_DEVICES][0]['specParams']:
Line 501: devices[WATCHDOG_DEVICES][0]['specParams']['action']
= 'none'
Line 502:
Line 503: # Normalize vdsm images
--
To view, visit http://gerrit.ovirt.org/9366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbbba925fa0c9be78b0eb5eb3d07066dc3b3c5ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
