Zhou Zheng Sheng has posted comments on this change. Change subject: pep8 fixes ......................................................................
Patch Set 1: (1 inline comment) fix of vdsm/vm.py is good, but I do not like removing the stack trace info in misc.py. .................................................... File vdsm/storage/misc.py Line 735: firstException = e Line 736: Line 737: # re-raise the earliest exception Line 738: if firstException is not None: Line 739: raise firstException We can log the exceptions as well as re-raise the first one with original stack trace. In this case the following exception sometimes is caused by an earlier exception, so the first exception is the most valuable one for investigating the problem. If the other exceptions are related to other problems, their log can be valuable as well. Reporting error W602 on three-args from of raise statement is a pep8 bug. The python-pep8 in EPEL6 is old, this bug has already been fixed in upstream. I submit a bug report at https://bugzilla.redhat.com/show_bug.cgi?id=878753 . Hope the EPEL maintainers can backport the fix. Line 740: Line 741: def defer(self, func, *args, **kwargs): Line 742: self._finally.append((func, args, kwargs)) Line 743: -- To view, visit http://gerrit.ovirt.org/9366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbbba925fa0c9be78b0eb5eb3d07066dc3b3c5ab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
