Edward Haas has posted comments on this change. Change subject: net: reconfigure bond detached from bridges ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/legacy_switch.py File lib/vdsm/network/legacy_switch.py: Line 665: 'Reconfigurating bond %s that were detached from bridge', bond) Line 666: configurator.configureBond(bond) Line 667: Line 668: Line 669: def _ifcfg_attached_to_bridge(iface_name): Should be implemented through the configurator API, it is ifcfg specific. Line 670: path = NET_CONF_PREF + iface_name Line 671: if os.path.isfile(path): Line 672: with open(path) as f: Line 673: for line in f.readlines(): https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: Line 137: Line 138: legacy_switch.add_missing_networks(configurator, networks, Line 139: bondings, _netinfo) Line 140: Line 141: legacy_switch.reconfigure_unbridged_bonds(configurator, _netinfo) I think it belongs at the tail of legacy_switch.bonds_setup, no? Is there a reason why it needs to be exposed at this abstraction level? Line 142: Line 143: connectivity.check(options) Line 144: Line 145: -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
