Edward Haas has posted comments on this change. Change subject: net: reconfigure bond detached from bridges ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: Line 137: Line 138: legacy_switch.add_missing_networks(configurator, networks, Line 139: bondings, _netinfo) Line 140: Line 141: legacy_switch.reconfigure_unbridged_bonds(configurator, _netinfo) > When bonds_setup takes place, some networks are not there and we are not ab If you put it like that: bonds_setup creates bonds attached to networks? I guess this is not true for new bonds, but may be true for edited ones (is it?). add_missing_networks edits the bonds and specify if they are slaves of a bridge (or a vlan). So it looks like we must have it after add_missing_networks and bonds_setup. After bonds_setup because the non-vlan network could have been removed in remove_networks and nothing added at add_missing. After add_missing because... Lets call it 'bonds_post_setup' to be less specific in this abstraction level. Line 142: Line 143: connectivity.check(options) Line 144: Line 145: -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
