Petr Horáček has posted comments on this change. Change subject: net: reconfigure bond detached from bridges ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: Line 137: Line 138: legacy_switch.add_missing_networks(configurator, networks, Line 139: bondings, _netinfo) Line 140: Line 141: legacy_switch.reconfigure_unbridged_bonds(configurator, _netinfo) > I think it belongs at the tail of legacy_switch.bonds_setup, no? Is there a When bonds_setup takes place, some networks are not there and we are not able to tell if the bond is to be detached from bridge or not. Well maybe we are! Do you think it would be better to pass networks to bonds_setup as well and check if used bridge-network is to be changed? Line 142: Line 143: connectivity.check(options) Line 144: Line 145: -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
